NewContext should use tiledb_ctx_alloc_with_error #223
Conversation
|
This pull request has been linked to Shortcut Story #18266: Use |
Shelnutt2
force-pushed
the
sethshelnutt/sc-18266/use-tiledb-ctx-alloc-with-error-to-capture
branch
from
8657c26 to
5eee8cd
Compare
This allows capturing any errors on alloc of the context.
Shelnutt2
force-pushed
the
sethshelnutt/sc-18266/use-tiledb-ctx-alloc-with-error-to-capture
branch
from
5eee8cd to
8c27f0b
Compare
| @@ -4,6 +4,7 @@ package tiledb | |||
| #cgo LDFLAGS: -ltiledb | |||
| #cgo linux LDFLAGS: -ldl | |||
| #include <tiledb/tiledb.h> | |||
| #include <tiledb/tiledb_experimental.h> | |||
There was a problem hiding this comment.
Since this is experimental, do we need to have a separate "experimental" vs. "non-experimental" file for this, with a flag like this:
TileDB-Go/array_schema_evolution.go
Line 1 in a1ad55b
(and a corresponding "not experimental" file)
There was a problem hiding this comment.
Well this API is experimental mostly because we don't know why allocs fail. Once we collect some of the errors that will inform us about the reasons and lead to possible API changes in which we might want to remove or change this with_error API.
There was a problem hiding this comment.
This is about separating things which use "experimental" TileDB APIs versus the stable ones, and the assumption that I assume we make that only stable APIs should be included when building without -tags=experimental. I have an example of what I mean by this here: 53e5e08
|
@snagles we should revist this to start collecting the errors. |
…-with-error-to-capture
|
CI fails because |
This allows capturing any errors on alloc of the context.